Fix test failure on macOS with link_section#2246
Open
ehuss wants to merge 1 commit intorust-lang:masterfrom
Open
Fix test failure on macOS with link_section#2246ehuss wants to merge 1 commit intorust-lang:masterfrom
ehuss wants to merge 1 commit intorust-lang:masterfrom
Conversation
rust-lang/rust#155065 recently added validation for link_section on macOS. I'm working around it here by just limiting this test to linux. Alternatives: - Show different syntaxes for different targets (but I would prefer to keep the example as plain as possible). - Mark it as `ignore` (want to avoid this if at all possible). Fixes rust-lang#2245
rustbot
added
the
S-waiting-on-review
Contributor
|
Thanks! This fix seems to work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#155065 recently added validation for link_section on macOS. I'm working around it here by just limiting this test to linux.
Alternatives:
ignore(want to avoid this if at all possible).Fixes #2245